Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ISSUE_TEMPLATE.md #18027

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Improve ISSUE_TEMPLATE.md #18027

merged 1 commit into from
Jan 15, 2018
+8 −0

Conversation

php-coder
Copy link
Contributor

I hope that this extra paragraph help our users to submit their issues into a proper repository. Any feedback is welcome!

PTAL @pweil- @sdodson @openshift/team-documentation
CC @simo5

@openshift-ci-robot openshift-ci-robot added retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2018
mfojtik
mfojtik reviewed Jan 9, 2018
View reviewed changes
.github/ISSUE_TEMPLATE.md
<!--
Note that this is the issue tracker for OpenShift Origin.

OpenShift Installer issues should be reported at https://github.com/openshift/openshift-ansible/issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe do similar for web-console? cc @jwforres

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. Console issues get filed in the wrong place a lot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwforres Added. PTAL.

mburke5678
mburke5678 reviewed Jan 9, 2018
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated
Note that this is the issue tracker for OpenShift Origin.

OpenShift Installer issues should be reported at https://github.com/openshift/openshift-ansible/issues
Documentation issues is better to report at https://github.com/openshift/openshift-docs/issues
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this page for? I wonder if there is a better mechanism for users to report documentation issues, if this page is for end users. Not sure how closely the openshift-docs/issues is monitored.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mburke5678 This is a template for a new issues. See the following link for details:

I wonder if there is a better mechanism for users to report documentation issues, if this page is for end users.

I don't know about such mechanism. Time to time, users reporting documentation issues here, but it happens not every day, so if you object against this paragraph, I will remove it.

Copy link

@mburke5678 mburke5678 Jan 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@php-coder Please leave the paragraph in. That is great!

Maybe change to Documentation issues should be reported at.... to keep the wording consistent?

@php-coder php-coder force-pushed the improve_gh_issue_template branch from f3b1541 to 0f13263 Compare January 9, 2018 14:23
@bparees bparees removed their request for review January 9, 2018 14:45
@sdodson
Copy link
Member

sdodson commented Jan 9, 2018

/approve
Fine with me

@php-coder
Copy link
Contributor Author

/assign @bparees
/assign @pweil-

@bparees
Copy link
Contributor

bparees commented Jan 9, 2018

/unassign
/assign @sdodson
/assign @jwforres

@openshift-ci-robot openshift-ci-robot assigned jwforres and sdodson and unassigned bparees Jan 9, 2018
jwforres
jwforres reviewed Jan 9, 2018
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated
Note that this is the issue tracker for OpenShift Origin.

OpenShift Installer issues should be reported at https://github.com/openshift/openshift-ansible/issues
Management Console issues are being collected at https://github.com/openshift/origin-web-console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link should go to the issues page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Updated. PTAL.

@php-coder php-coder force-pushed the improve_gh_issue_template branch from 0f13263 to 232751e Compare January 10, 2018 12:10
@jwforres
Copy link
Member

Console bit looks fine
/approve

@php-coder
Copy link
Contributor Author

Test flake #16273
/test cmd

@mfojtik
Copy link
Contributor

mfojtik commented Jan 10, 2018

/approve no-issue

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2018
adellape
adellape reviewed Jan 10, 2018
View reviewed changes
.github/ISSUE_TEMPLATE.md
OpenShift Installer issues should be reported at https://github.com/openshift/openshift-ansible/issues
Management Console issues are collected at https://github.com/openshift/origin-web-console/issues
Documentation issues are better reported at https://github.com/openshift/openshift-docs/issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@php-coder
Copy link
Contributor Author

@soltysh Could you look at it and put LGTM if it deserves? :)

pweil-
pweil- approved these changes Jan 15, 2018
View reviewed changes
Copy link

@pweil- pweil- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pweil-
Copy link

pweil- commented Jan 15, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwforres, mfojtik, php-coder, pweil-, sdodson

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 793835e into openshift:master Jan 15, 2018
@php-coder php-coder deleted the improve_gh_issue_template branch January 15, 2018 20:48
@php-coder
Copy link
Contributor Author

@pweil- Thank you, Paul!

@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2018

I see my buddy @pweil- was faster than I ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik mfojtik left review comments

@jwforres jwforres jwforres left review comments

@adellape adellape adellape left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@pweil- pweil- pweil- approved these changes

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@sdodson sdodson

@jwforres jwforres

@pweil- pweil-

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.