Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix -o panic oc rollback #18040

Merged
merged 2 commits into from
Jan 15, 2018
Merged

fix -o panic oc rollback #18040

merged 2 commits into from
Jan 15, 2018

Conversation

juanvallejo
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532527

Fix panic caused by a missing no-headers flag.
Add support for json format output in oc rollout dc/...

  • previously, it was possible to specify the flag for the command, but it was ignored

cc @openshift/cli-review @soltysh

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2018
@juanvallejo
Copy link
Contributor Author

/retest

@juanvallejo juanvallejo force-pushed the jvallejo/fix-generic-output-rollback branch from e07bb2a to 5428dd7 Compare January 11, 2018 23:50
soltysh
soltysh approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2018
@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2018

/retest

@juanvallejo
Copy link
Contributor Author

/test cmd
/test extended_conformance_install

@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor

soltysh commented Jan 15, 2018

/test all

@juanvallejo
Copy link
Contributor Author

/test unit

@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18040, 18097, 18098, 18106, 18087).

@openshift-merge-robot openshift-merge-robot merged commit 0934913 into openshift:master Jan 15, 2018
@openshift-ci-robot
Copy link

@juanvallejo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 5428dd7 link /test cmd
ci/openshift-jenkins/unit 5428dd7 link /test unit
ci/openshift-jenkins/extended_conformance_gce 5428dd7 link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install 5428dd7 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juanvallejo juanvallejo deleted the jvallejo/fix-generic-output-rollback branch January 15, 2018 23:38
@juanvallejo juanvallejo mentioned this pull request Jan 17, 2018
Merged
openshift-merge-robot added a commit that referenced this pull request Jan 22, 2018
@openshift-merge-robot
Merge pull request #18142 from juanvallejo/jvallejo/fix-generic-outpu…
12c0c5e 
…t-oc-rollback

Automatic merge from submit-queue (batch tested with PRs 18074, 18004, 18142, 18162, 18169).

fix generic output in oc rollback

Followup to #18040

Prints the external version of a rolledback deploymentconfig.

cc @soltysh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanvallejo @openshift-ci-robot @soltysh @openshift-bot @openshift-merge-robot