Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump router to haprox18 #18053

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Bump router to haprox18 #18053

merged 2 commits into from
Jan 11, 2018

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Jan 10, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2018
smarterclayton
smarterclayton reviewed Jan 10, 2018
View reviewed changes
images/router/haproxy/Dockerfile Outdated
RUN INSTALL_PKGS="haproxy" && \
RUN INSTALL_PKGS="haproxy18" && \
yum install yum-config-manager && \
yum-config-manager --add http://cbs.centos.org/repos/paas7-openshift-origin38-testing/x86_64/os/ && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the haproxy18 package in the normal set of dependencies we already set? We spent 2 releases trying to stop doing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you meant "why ISN'T the haproxy18..."

@sdodson
Copy link
Member Author

sdodson commented Jan 10, 2018

/test extended_networking_minimal

1 similar comment
@sdodson
Copy link
Member Author

sdodson commented Jan 10, 2018

/test extended_networking_minimal

knobunc
knobunc approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2018
@knobunc
Copy link
Contributor

knobunc commented Jan 10, 2018

/retest

knobunc and others added 2 commits January 10, 2018 16:44
@knobunc @sdodson
Bump the haproxy version to 1.8
d0aa776 
This just uses the new OpenShift repo RPMs for haproxy 1.8.  There should be no features changed by this.  All follow-on work making use of the new features in haproxy will happen in subsequent commits.
@sdodson
router- Temporarily add centos paas sig 3.8
53762de 
We're awaiting a signed version of this package.
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2018
@sdodson sdodson changed the title WIP haproxy repo hack Bump router to haprox18 Jan 10, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2018
@knobunc
Copy link
Contributor

knobunc commented Jan 10, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, sdodson

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

What is the resolution of the concerns raised earlier? This is going to be fixed tomorrow?

@eparis
Copy link
Member

eparis commented Jan 10, 2018

We hope tomorrow to revert the repo swizzle. Right now we are just trying to get it to work at all...

@smarterclayton
Copy link
Contributor

Ok, that's fine.

@knobunc knobunc mentioned this pull request Jan 11, 2018
Closed
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit d73139f into openshift:master Jan 11, 2018
rajatchopra
rajatchopra reviewed Jan 11, 2018
View reviewed changes
Copy link
Contributor

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo name is origin38-testing? Sounds timeboxed.

@ghyde ghyde mentioned this pull request Jan 18, 2018
Merged
@sdodson sdodson deleted the pr17990 branch May 11, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatchopra rajatchopra rajatchopra left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@eparis eparis eparis left review comments

@knobunc knobunc knobunc approved these changes

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sdodson @knobunc @openshift-ci-robot @smarterclayton @eparis @openshift-merge-robot @rajatchopra