Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webconsole.config.openshift.io/v1 API group #18056

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Use webconsole.config.openshift.io/v1 API group #18056

merged 1 commit into from
Jan 13, 2018

Conversation

spadgett
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2018
@spadgett
Copy link
Member Author

We might need to wait until there's a v3.9.0-alpha.2. Cluster up with fail with alpha.1 with these changes since it won't recognize the new type.

@deads2k
Copy link
Contributor

deads2k commented Jan 11, 2018

/lgtm

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, spadgett

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2018
@deads2k
Copy link
Contributor

deads2k commented Jan 11, 2018

@stevekuznetsov @bparees Where do we capture the container logs for the clusterup tests? https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18056/test_pull_request_origin_extended_clusterup/286/

@deads2k
Copy link
Contributor

deads2k commented Jan 11, 2018

We might need to wait until there's a v3.9.0-alpha.2. Cluster up with fail with alpha.1 with these changes since it won't recognize the new type.

@smarterclayton Can we get a new tag? We just switched API objects and I'd like to complete the cut over

@spadgett spadgett mentioned this pull request Jan 11, 2018
Merged
@bparees bparees removed their request for review January 11, 2018 15:07
@spadgett spadgett force-pushed the console-config-api-group branch from 3ff3594 to 0ac3f9d Compare January 11, 2018 15:44
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
openshift-merge-robot added a commit to openshift/openshift-ansible that referenced this pull request Jan 11, 2018
@openshift-merge-robot
Merge pull request #6701 from spadgett/webconsole-config-group
e347c3e 
Automatic merge from submit-queue.

Use webconsole.config.openshift.io/v1 API group

Update the install to use the new web console config API group and kind.

API change: openshift/api#29
Cluster up change: openshift/origin#18056

/assign @sdodson 
@deads2k @jwforres cc
@spadgett
Copy link
Member Author

/retest

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

/retest

5 similar comments
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 3c75f9a into openshift:master Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spadgett @deads2k @openshift-ci-robot @openshift-bot @openshift-merge-robot