Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admission registration #18063

Closed
wants to merge 2 commits into from
Closed

admission registration #18063

wants to merge 2 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 11, 2018

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 11, 2018
mfojtik
mfojtik reviewed Jan 11, 2018
View reviewed changes
vendor/k8s.io/kubernetes/plugin/pkg/admission/eventratelimit/admission.go
@@ -43,6 +44,10 @@ func Register(plugins *admission.Plugins) {
}
return newEventRateLimit(configuration, realClock{})
})

// add our config types
eventratelimitapi.AddToScheme(plugins.ConfigScheme)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need imagepolicy as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need imagepolicy as well?

didn't come up in kube. probably.

@mfojtik
Copy link
Contributor

mfojtik commented Jan 15, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 15, 2018

closing in favor of #18111

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2018 •
edited
Loading

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 2f43799 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k closed this Jan 15, 2018
@deads2k deads2k deleted the server-57-admission-registration branch January 24, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik mfojtik left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @openshift-ci-robot @mfojtik @openshift-merge-robot