Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull haproxy from the right place #18066

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

eparis
Copy link
Member

@eparis eparis commented Jan 11, 2018

This reverts the hack that we added to pull directly from a testing repo. Once the image rolls out to the mirrors the hack is not needed. This reverts it.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2018
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @eparis

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@eparis
Copy link
Member Author

eparis commented Jan 11, 2018

/lgtm cancel
since I have debug code in there...

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@knobunc
Copy link
Contributor

knobunc commented Jan 11, 2018

/hold

So I don't lgtm it again by mistake.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2018
@eparis
Copy link
Member Author

eparis commented Jan 11, 2018

/lgtm
so we can just remove the hold :)

@openshift-ci-robot
Copy link

@eparis: you cannot LGTM your own PR.

In response to this:

/lgtm
so we can just remove the hold :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2018
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@eparis
Copy link
Member Author

eparis commented Jan 11, 2018

stolen from #18073

@knobunc
Copy link
Contributor

knobunc commented Jan 11, 2018

/lgtm

@eparis should I incorporate that in my test PR?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@smarterclayton smarterclayton removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2018
@smarterclayton
Copy link
Contributor

Rebase this on my commit, we shouldn't be mixing the multi arch repo with the dependency repo.

@eparis eparis force-pushed the haproxy-1.8-fix branch 2 times, most recently from ce22e1f to 43f15e2 Compare January 11, 2018 21:26
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2018
@eparis
Copy link
Member Author

eparis commented Jan 12, 2018

All day, so much useless wheel spinning by me and @smarterclayton and this is what works.
/hold cancel
/lgtm

@openshift-ci-robot
Copy link

@eparis: you cannot LGTM your own PR.

In response to this:

All day, so much useless wheel spinning by me and @smarterclayton and this is what works.
/hold cancel
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, knobunc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@eparis eparis added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2018
@eparis
Copy link
Member Author

eparis commented Jan 12, 2018

/retest

2 similar comments
@eparis
Copy link
Member Author

eparis commented Jan 12, 2018

/retest

@eparis
Copy link
Member Author

eparis commented Jan 12, 2018

/retest

@smarterclayton
Copy link
Contributor

lgtm

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 12, 2018 via email

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18066, 18079).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/routing lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants