-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull haproxy from the right place #18066
Pull haproxy from the right place #18066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @eparis
/lgtm cancel |
/hold So I don't lgtm it again by mistake. |
/lgtm |
@eparis: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stolen from #18073 |
/lgtm @eparis should I incorporate that in my test PR? |
Rebase this on my commit, we shouldn't be mixing the multi arch repo with the dependency repo. |
ce22e1f
to
43f15e2
Compare
43f15e2
to
90a1310
Compare
All day, so much useless wheel spinning by me and @smarterclayton and this is what works. |
@eparis: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, knobunc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
2 similar comments
/retest |
/retest |
lgtm |
/retest
after AMI revert
…On Fri, Jan 12, 2018 at 2:20 PM, OpenShift CI Robot < ***@***.***> wrote:
@eparis <https://github.com/eparis>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 90a1310
<90a1310>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18066/test_pull_request_origin_extended_conformance_install/5430/> /test
extended_conformance_install
Full PR test history <https://openshift-gce-devel.appspot.com/pr/18066>. Your
PR dashboard <https://openshift-gce-devel.appspot.com/pr/eparis>. Please
help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/origin/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/devel/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18066 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pynuunuUbvacemn8PaMlIBBfDDiaks5tJ7AFgaJpZM4Ra79k>
.
|
Automatic merge from submit-queue (batch tested with PRs 18066, 18079). |
This reverts the hack that we added to pull directly from a testing repo. Once the image rolls out to the mirrors the hack is not needed. This reverts it.