remove oauth server dependency from most integration tests #18067
Conversation
openshift-ci-robot
added
approved
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
yeah, weird, right? |
| oauthapi "github.com/openshift/origin/pkg/oauth/apis/oauth" | ||
| oauthclient "github.com/openshift/origin/pkg/oauth/generated/internalclientset" | ||
| "github.com/openshift/origin/pkg/serviceaccounts" | ||
| userapi "github.com/openshift/origin/pkg/user/apis/user" | ||
| userclient "github.com/openshift/origin/pkg/user/generated/internalclientset" |
There was a problem hiding this comment.
still dependent on internal apis and auth, i guess i'm not seeing how i copy this pattern.
There was a problem hiding this comment.
still dependent on internal apis and auth, i guess i'm not seeing how i copy this pattern.
Hrm. All our integration tests are still on internal. I don't think I've done anything special that's internal only. Can you copy it and change the package imports to the externals?
There was a problem hiding this comment.
maybe. it's bitten me in other places but i can try it.
|
That's one way to force a valid token 😄 |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@deads2k fyi this appears to have let me move forward in image-registry, thanks! |
/assign liggitt enj
@bparees I think this breaks the back of the problem. There are stragglers in the origin integration tests that I'll try to mop up at some later date, but this gives you back a working token.
@smarterclayton fyi