Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster capacity rebase to kubernetes 1.9 #18088

Merged
merged 2 commits into from
Jan 13, 2018
Merged

Cluster capacity rebase to kubernetes 1.9 #18088

merged 2 commits into from
Jan 13, 2018

Conversation

aveshagarwal
Copy link
Contributor

Still doing some testing.

@sjenning FYI

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2018
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 12, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 12, 2018
@ingvagabund
Copy link
Member

Nice kitty: https://github.com/openshift/origin/pull/18088/files#diff-12ec0e09fe110f50616e20d165cfb06d

@sjenning
Copy link
Contributor

Nice kitty: https://github.com/openshift/origin/pull/18088/files#diff-12ec0e09fe110f50616e20d165cfb06d

what the?!

@aveshagarwal
Copy link
Contributor Author

I looked into test failures and I dont think any test failure is related to cluster capacity update.

@aveshagarwal aveshagarwal changed the title [WIP] Cluster capacity rebase to kubernetes 1.9 Cluster capacity rebase to kubernetes 1.9 Jan 12, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2018
@aveshagarwal
Copy link
Contributor Author

/test unit
/test extended_conformance_gce
/test extended_conformance_install

@aveshagarwal
Copy link
Contributor Author

@sjenning it passed all tests now. who can tag lgtm?

@sjenning
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18086, 18088).

@openshift-merge-robot openshift-merge-robot merged commit b25521a into openshift:master Jan 13, 2018
@aveshagarwal aveshagarwal deleted the master-cluster-capacity-rebase-kube19 branch January 19, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodovska hodovska Awaiting requested review from hodovska

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aveshagarwal @ingvagabund @sjenning @openshift-ci-robot @openshift-merge-robot