Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include proto swagger in discovery #18105

Merged
merged 1 commit into from
Jan 14, 2018
Merged

Include proto swagger in discovery #18105

merged 1 commit into from
Jan 14, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jan 12, 2018

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2018
@juanvallejo
Copy link
Contributor

/retest

1 similar comment
@liggitt
Copy link
Contributor Author

liggitt commented Jan 13, 2018

/retest

@liggitt liggitt added this to the 3.8.0 milestone Jan 13, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Jan 13, 2018

cc @openshift/sig-security
pick of 1.9 fix

@enj
Copy link
Contributor

enj commented Jan 13, 2018

/lgtm

Still as ugly as the first time I saw it.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 5cc095e into openshift:release-3.8 Jan 14, 2018
@juanvallejo
Copy link
Contributor

/cherrypick release-3.7

To address https://bugzilla.redhat.com/show_bug.cgi?id=1538954

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2018
Merged
@openshift-cherrypick-robot
Copy link

@juanvallejo: new pull request created: #18309

In response to this:

/cherrypick release-3.7

To address https://bugzilla.redhat.com/show_bug.cgi?id=1538954

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot added a commit that referenced this pull request Jan 29, 2018
@openshift-merge-robot
Merge pull request #18309 from openshift-cherrypick-robot/cherry-pick…
284b8b7 
…-18105-to-release-3.7

Automatic merge from submit-queue.

[release-3.7] Include proto swagger in discovery

This is an automated cherry-pick of #18105

/assign juanvallejo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelton adelton Awaiting requested review from adelton

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review sig/security size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @juanvallejo @enj @openshift-ci-robot @openshift-merge-robot @openshift-cherrypick-robot