Fix cluster-capacity functionality as a pod. #18198
Conversation
openshift-ci-robot
added
size/S
|
Flake: #17897 |
|
/test extended_conformance_gce |
|
/retest |
|
@aveshagarwal: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sjenning can you tag lgtm? |
|
|
||
| COPY hypercc /bin/hypercc | ||
| RUN ln -sf /bin/hypercc /bin/cluster-capacity | ||
| RUN ln -sf /bin/hypercc /bin/genpod | ||
| COPY config/default-scheduler.yaml /config/default-scheduler.yaml |
There was a problem hiding this comment.
it is used when a customized scheduler config is passed, which should be done via configmap.
There was a problem hiding this comment.
No need to hard code or embed in the image.
There was a problem hiding this comment.
Do we document where this configmap should be mounted inside the container?
There was a problem hiding this comment.
In https://docs.openshift.com/container-platform/3.7/admin_guide/cluster_capacity.html, we have documented how to mount pod spec via configmap but not customized scheduler config as mostly one does not need that. That said, the above documented can be updated with description about how to mount scheduler config as a ConfigMap in a pod.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aveshagarwal, sjenning The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 17857, 18252, 18198). |
Fix https://bugzilla.redhat.com/show_bug.cgi?id=1535940
@wjiangjay @sjenning