-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 58301: Limit all category to apps group for ds/deployment/r… #18219
Conversation
do we need it for our resources that are surfaced in two groups as well? looks like the original bz referenced routes |
Already fixed. Hence my comment about, "try doing this" for you. Regrettably, I thought of it post-merge. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@smarterclayton @stevekuznetsov I don't see the gcp job in prow. Am I just missing it? |
/retest |
Automatic merge from submit-queue. |
/cherrypick release-3.7 |
@juanvallejo: #18219 failed to apply on top of branch "release-3.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…imit-all Automatic merge from submit-queue. Backport origin pr 18219 limit all Picks kubernetes/kubernetes#49624 Picks #18219 Depends on #18476 Addresses #18473 (comment) cc @deads2k
…eplicaset
@juanvallejo @liggitt fixed it upstream, we just need to pick it.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1523493
/assign liggitt
/assign @juanvallejo