Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 58301: Limit all category to apps group for ds/deployment/r… #18219

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 22, 2018

…eplicaset

@juanvallejo @liggitt fixed it upstream, we just need to pick it.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1523493

/assign liggitt
/assign @juanvallejo

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Jan 22, 2018
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2018
@liggitt
Copy link
Contributor

liggitt commented Jan 22, 2018

do we need it for our resources that are surfaced in two groups as well? looks like the original bz referenced routes

@deads2k
Copy link
Contributor Author

deads2k commented Jan 22, 2018

do we need it for our resources that are surfaced in two groups as well? looks like the original bz referenced routes

Already fixed. Hence my comment about, "try doing this" for you. Regrettably, I thought of it post-merge.

@juanvallejo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Jan 22, 2018

@smarterclayton @stevekuznetsov I don't see the gcp job in prow. Am I just missing it?

@smarterclayton
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 866b193 into openshift:master Jan 23, 2018
@deads2k deads2k deleted the server-60-all branch January 24, 2018 14:29
@juanvallejo
Copy link
Contributor

/cherrypick release-3.7

@openshift-cherrypick-robot

@juanvallejo: #18219 failed to apply on top of branch "release-3.7":

Using index info to reconstruct a base tree...
A	vendor/k8s.io/kubernetes/hack/make-rules/test-cmd-util.sh
M	vendor/k8s.io/kubernetes/pkg/registry/extensions/daemonset/storage/storage.go
M	vendor/k8s.io/kubernetes/pkg/registry/extensions/deployment/storage/storage.go
M	vendor/k8s.io/kubernetes/pkg/registry/extensions/replicaset/storage/storage.go
M	vendor/k8s.io/kubernetes/pkg/registry/extensions/rest/storage_extensions.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/k8s.io/kubernetes/pkg/registry/extensions/rest/storage_extensions.go
Auto-merging vendor/k8s.io/kubernetes/pkg/registry/extensions/replicaset/storage/storage.go
Auto-merging vendor/k8s.io/kubernetes/pkg/registry/extensions/deployment/storage/storage.go
Auto-merging vendor/k8s.io/kubernetes/pkg/registry/extensions/daemonset/storage/storage.go
CONFLICT (content): Merge conflict in vendor/k8s.io/kubernetes/pkg/registry/extensions/daemonset/storage/storage.go
Auto-merging cmd/cluster-capacity/go/src/github.com/kubernetes-incubator/cluster-capacity/vendor/k8s.io/kubernetes/hack/make-rules/test-cmd-util.sh
CONFLICT (content): Merge conflict in cmd/cluster-capacity/go/src/github.com/kubernetes-incubator/cluster-capacity/vendor/k8s.io/kubernetes/hack/make-rules/test-cmd-util.sh
error: Failed to merge in the changes.
Patch failed at 0001 UPSTREAM: 58301: Limit all category to apps group for ds/deployment/replicaset

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot added a commit that referenced this pull request Feb 9, 2018
…imit-all

Automatic merge from submit-queue.

Backport origin pr 18219 limit all

Picks kubernetes/kubernetes#49624
Picks #18219

Depends on #18476

Addresses #18473 (comment)

cc @deads2k
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants