UPSTREAM: <carry>: hack in working autoscale reference for oc autoscale #18376
Conversation
openshift-ci-robot
added
approved
openshift-merge-robot
added
the
vendor-update
| @@ -131,6 +131,11 @@ func RunAutoscale(f cmdutil.Factory, out io.Writer, cmd *cobra.Command, args []s | |||
| params["scaleRef-name"] = name | |||
| params["scaleRef-apiVersion"] = mapping.GroupVersionKind.GroupVersion().String() | |||
|
|
|||
| // hack to make scaling DCs work. | |||
| if mapping.GroupVersionKind.Kind == "DeploymentConfig" && len(mapping.GroupVersionKind.Group) == 0 { | |||
There was a problem hiding this comment.
hm, this hurts to read :)
|
lgtm, could we add a test under test/cmd, perhaps? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
test added |
|
/retest |
|
/test extended_conformance_install |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Issue to properly fix this? |
|
Automatic merge from submit-queue (batch tested with PRs 18376, 18355). |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I don't think there will ever be another case of this. This requires creating a separate API version |
I lost your bugzilla. This adds a nasty hack to recognize that we need to specify a different group for autoscaling DCs.
/assign @DirectXMan12
/assign @juanvallejo