UPSTREAM: 59316: Exit if no client cert is available for 5m #18430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/M
openshift-merge-robot
added
the
vendor-update
|
/retest |
soltysh
approved these changes
Feb 5, 2018
|
Upstream has merged. Any comments? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smarterclayton you want to cherry-pick that to 3.9? |
|
Automatic merge from submit-queue (batch tested with PRs 18666, 18810, 18430, 18517, 18653). |
openshift-merge-robot
added a commit
to openshift/openshift-ansible
that referenced
this pull request
Mar 11, 2018
Automatic merge from submit-queue. Make openshift-ansible use static pods to install the control plane, make nodes prefer bootstrapping 1. Nodes continue to be configured for bootstrapping (as today) 2. For bootstrap nodes, we write a generic bootstrap-node-config.yaml that contains static pod references and any bootstrap config, and then use that to start a child kubelet using `--write-flags` instead of launching the node ourselves. If a node-config.yaml is laid down in `/etc/origin/node` it takes precedence. 3. For 3.10 we want dynamic node config from Kubernetes to pull down additional files, but there are functional gaps. For now, the openshift SDN container has a sidecar that syncs node config to disk and updates labels (kubelet doesn't update labels, kubernetes/kubernetes#59314) 4. On the masters, if openshift_master_bootstrap_enabled we generate the master-config.yaml and the etcd config, but we don't start etcd or the masters (no services installed) 5. On the masters, we copy the static files into the correct pod-manifest-path (/etc/origin/node/pods) or similar 6. The kubelet at that point should automatically pick up the new static files and launch the components 7. We wait for them to converge 8. We install openshift-sdn as the first component, which allows nodes to go ready and start installing things. There is a gap here where the masters are up, the nodes can bootstrap, but the nodes are not ready because no network plugin is installed. Challenges at this point: * The master shims (`master-logs` and `master-restart`) need to deal with CRI-O and systemd. Ideally this is a temporary shim until we remove systemd for these components and have cri-ctl installed. * We need to test failure modes of the static pods * Testing Further exploration things: * need to get all the images using image streams or properly replaced into the static pods * need to look at upgrades and updates * disk locations become our API (`/var/lib/origin`, `/var/lib/etcd`) - how many customers have fiddled with this? * may need to make the kubelet halt if it hasn't been able to get server/client certs within a bounded window (5m?) so to ensure that autoheals happen (openshift/origin#18430) * have to figure out whether dynamic kubelet config is a thing we can rely on for 3.10 (@liggitt), and what gaps there are with dynamic reconfig * client-ca.crt is not handled by bootstrapping or dynamic config. This needs a solution unless we keep the openshift-sdn sidecar around * kubelet doesn't send sd notify to systemd (kubernetes/kubernetes#59079) @derekwaynecarr @sdodson @liggitt @deads2k this is the core of self-hosting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.