Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Admission plugin: openshift.io/ImageQualify" #18605

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

sjenning
Copy link
Contributor

This reverts commit 8bc3e07. #18020

Render unneeded by upstream kubernetes/kubernetes#58955 and Origin pick #18340

Will live on forever in git history if we find a use case for it later.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2018
@liggitt
Copy link
Contributor

liggitt commented Feb 14, 2018

F0214 02:53:03.813721 18975 main.go:74] Error: Failed making a parser: unable to add directory "github.com/openshift/origin/pkg/image/admission/apis/imagequalify": unable to import "github.com/openshift/origin/pkg/image/admission/apis/imagequalify": cannot find package "github.com/openshift/origin/pkg/image/admission/apis/imagequalify" in any of:

@sjenning
Copy link
Contributor Author

/retest

@derekwaynecarr derekwaynecarr added this to the 3.9.0 milestone Feb 15, 2018
@derekwaynecarr
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18624, 18605).

@openshift-merge-robot openshift-merge-robot merged commit 7313d6e into openshift:master Feb 15, 2018
@openshift-ci-robot
Copy link

@sjenning: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp f568952 link /test gcp
ci/openshift-jenkins/extended_conformance_install f568952 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants