Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handleDeleteSubnet() to release network from subnet allocator #18801

Merged
merged 1 commit into from
Mar 3, 2018
Merged

Fix handleDeleteSubnet() to release network from subnet allocator #18801

merged 1 commit into from
Mar 3, 2018

Conversation

pravisankar
Copy link

This was introduced in #16766

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2018
@pravisankar
Copy link
Author

@openshift/sig-networking PTAL

@imcsk8
Copy link
Contributor

imcsk8 commented Mar 2, 2018

LGTM

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pravisankar
Copy link
Author

/cherrypick release-3.9

@openshift-cherrypick-robot
Copy link

@pravisankar: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18601, 18751, 18540, 18767, 18801).

@openshift-merge-robot openshift-merge-robot merged commit acc56c4 into openshift:master Mar 3, 2018
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 3, 2018
Merged
@openshift-cherrypick-robot
Copy link

@pravisankar: new pull request created: #18819

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot added a commit that referenced this pull request Mar 6, 2018
@openshift-merge-robot
Merge pull request #18819 from openshift-cherrypick-robot/cherry-pick…
2ca7a16 
…-18801-to-release-3.9

Automatic merge from submit-queue.

[release-3.9] Fix handleDeleteSubnet() to release network from subnet allocator

This is an automated cherry-pick of #18801

/assign pravisankar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/networking lgtm Indicates that a PR is ready to be merged. sig/networking size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pravisankar @imcsk8 @danwinship @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot