Register audit/v1beta1 for master config #18811
Conversation
openshift-ci-robot
added
the
size/XS
|
This and #18751 are needed in 3.9 |
|
/cherrypick release-3.9 |
|
@soltysh: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -242,7 +242,7 @@ func ValidateAuditConfig(config configapi.AuditConfig, fldPath *field.Path) Vali | |||
| } else { | |||
| policyConfiguration, ok := config.PolicyConfiguration.(*auditinternal.Policy) | |||
| if !ok { | |||
| validationResults.AddErrors(field.Invalid(fldPath.Child("policyConfiguration"), config.PolicyConfiguration, "must be of type audit/v1alpha1.Policy")) | |||
There was a problem hiding this comment.
message is wrong. it should allow both.
There was a problem hiding this comment.
If you have audit/v1alpha1 it won't complain. If you don't I'd prefer you use v1beta1, that's why I went with that.
|
Once bitten deserves a test I'd think. That would also ensure my other fixes don't accidentally regress. test-integration will let you wire it to a file and to an embedded. |
|
Yeah, I agree with the test, will add one on Monday. |
openshift-ci-robot
added
size/M
|
/retest |
|
@deads2k I've added the tests you've asked for, ptal |
|
Doesn't work, but /lgtm As long as the tests stay. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
I had to change that embed tests to use internal types only, not sure why or how but it works just fine for me locally, but failed (which I'd expect) on our CI. |
|
/retest |
1 similar comment
|
/retest |
|
/test gcp |
|
/test extended_networking_minimal |
|
/retest |
1 similar comment
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@soltysh: new pull request created: #18893 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #18752.
/assign @deads2k
/cherry-pick 3.9