Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.9] sdn: fix CNI IPAM data dir #18863

Merged
merged 1 commit into from
Mar 8, 2018
Merged

[release-3.9] sdn: fix CNI IPAM data dir #18863

merged 1 commit into from
Mar 8, 2018

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #18779

/assign pravisankar

@dcbw
sdn: fix CNI IPAM data dir
dac0469 
Data directory passed to the CNI host-local delegate plugin
should be /var/lib/cni/networks, but the original patch missed
one place to append "/networks" (the one that mattered).

Fix-up for openshift#18404

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1549491
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2018
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2018
@pravisankar
Copy link

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2018
@knobunc
Copy link
Contributor

knobunc commented Mar 6, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@eparis eparis added the kind/bug Categorizes issue or PR as related to a bug. label Mar 7, 2018
@eparis eparis added this to the 3.9.0 milestone Mar 7, 2018
@eparis eparis modified the milestones: v3.9, 3.7.0 Mar 7, 2018
@pravisankar
Copy link

/retest

@eparis eparis removed the queue/fix label Mar 7, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 1c027c1 into openshift:release-3.9 Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@pravisankar pravisankar Awaiting requested review from pravisankar

Assignees

@pravisankar pravisankar

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/networking kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @pravisankar @knobunc @openshift-ci-robot @openshift-bot @openshift-merge-robot @eparis @dcbw