Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create hypershift openshift-controller-manager #18887

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 7, 2018

Adds openshift-controller-manager and cleans up a PV recycler patch I found.

The openshift start master delegates here to limit duplication.

/assign @mfojtik
@openshift/sig-master

@openshift-ci-robot openshift-ci-robot added sig/master size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 7, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 7, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Mar 7, 2018

/test all

@mfojtik
Copy link
Contributor

mfojtik commented Mar 8, 2018

/retest

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although you need to fix the integration tests

@deads2k deads2k force-pushed the hypershift-06-controller branch from 1b24732 to 6ad6ff2 Compare March 8, 2018 17:30
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2018
@deads2k deads2k force-pushed the hypershift-06-controller branch from 6ad6ff2 to e2a9f3e Compare March 8, 2018 17:56
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2018
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Mar 9, 2018

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Mar 9, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Mar 9, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18887, 18741).

@openshift-merge-robot openshift-merge-robot merged commit d05fad9 into openshift:master Mar 9, 2018
@deads2k deads2k deleted the hypershift-06-controller branch July 3, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/master size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants