Allow subnet allocator to mark assigned subnet dynamically #18999
Conversation
openshift-ci-robot
added
the
size/L
|
@openshift/sig-networking PTAL |
pravisankar
force-pushed
the
expose-marking-suballocator
branch
from
37e2a24 to
23bbe1f
Compare
|
We should just move subnet_allocator.go into pkg/network/master. It's more an implementation detail of the SDN master than it is a general "utility". In particular, I was going to say that you should drop the |
pravisankar
force-pushed
the
expose-marking-suballocator
branch
from
23bbe1f to
fe6f105
Compare
|
@openshift/sig-networking @danwinship Updated, PTAL @smarterclayton @deads2k @liggitt @mfojtik @soltysh can one of you approve pkg/util changes? |
- Subnet allocator is specific to SDN master and not used anywhere.
- Currently, we need to pass all allocated subnets during subnet allocator creation time (inUse arg to NewSubnetAllocator()). This means we need to know all existing subnets beforehand. - This change exposes additional method so that we can mark a specific subnet as already allocated dynamically (after the subnet allocator is created). Precursor for openshift#18911
pravisankar
force-pushed
the
expose-marking-suballocator
branch
from
fe6f105 to
9f5339f
Compare
|
/retest |
|
/approve |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pravisankar, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test gcp |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 18999, 18543). |
Moved subnet allocator from pkg/util/netutils to pkg/network/master
Subnet allocator is specific to SDN master and not used anywhere.
Currently, we need to pass all allocated subnets during
subnet allocator creation time (inUse arg to NewSubnetAllocator()).
This means we need to know all existing subnets beforehand.
This change exposes additional method so that we can mark a
specific subnet as already allocated dynamically (after the subnet
allocator is created).
Precursor for #18911