Clean up mirror and support quay.io pushing #19016
Conversation
openshift-ci-robot
added
size/L
|
@smarterclayton is it a typo or does quay really not have schema 1 support? |
|
Typo, they lack schema2 (are working on it now) |
|
Any comments? I'm trying to get mirror ready to sync lots of images to quay, then I'll start adding test suites around it. More iterative dev right now so we can get to a beta state for this command. |
| } | ||
| line = strings.TrimSpace(line) | ||
| if len(line) == 0 { | ||
| continue |
There was a problem hiding this comment.
It will go to the next line without incrementing lineNumber.
|
Converting schema 2 into schema 1 looks good. Everything else doesn't seem changed. |
|
Thanks, updated |
openshift-ci-robot
added
size/XXL
Enable short term quay.io support (which doesn't support schema1) by down converting when we get an invalid manifest error. Also support arguments from file.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
size/L
|
/retest |
|
Tagging based on comments, let me know if there's something still to change and I'll do it in the follow on to this PR (adding planning for a mirror) |
|
stupid job, work |
|
/test cmd |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 18905, 18968, 19016, 19037, 19056). |
quay.io doesn't have schema2 support yet, tolerate it in oc image mirror. Also add file support.
Does some preparator refactoring for adding parallel pushing support.