Some route status updates were being lost #19018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/L
If two work functions are added for the same key, the second one should get invoked even if queue is currently processing the first function.
smarterclayton
force-pushed
the
avoid_loss
branch
from
9535aee to
f5a323b
Compare
smarterclayton
added
component/networking
component/routing
kind/test-flake
|
/retest |
Only delete the key if the function we executed is the last function.
smarterclayton
force-pushed
the
avoid_loss
branch
from
f5a323b to
5237978
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previous behavior was incorrect - at least one client will get through.
smarterclayton
force-pushed
the
avoid_loss
branch
from
379fa29 to
2acf88d
Compare
|
/retest |
|
Merging to fix flakes |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new writer lease code when encountering a conflict would drop the queued work, causing status not to be written
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18930/test_pull_request_origin_extended_conformance_gce/17834/#conformanceareanetworkingfeaturerouter-the-haproxy-router-converges-when-multiple-routers-are-writing-status-suiteopenshiftconformanceparallel
This could cause tests that depend on route status to fail
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19018/test_pull_request_origin_extended_conformance_gce/17839/#conformanceareanetworkingfeaturerouter-the-haproxy-router-should-support-reencrypt-to-services-backed-by-a-serving-certificate-automatically-suiteopenshiftconformanceparallel