Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] UPSTREAM: 59931: do not delete node in openstack, if those still exist in cloudprovider #19051

Closed
wants to merge 1 commit into from
Closed

[3.9] UPSTREAM: 59931: do not delete node in openstack, if those still exist in cloudprovider #19051

wants to merge 1 commit into from

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 21, 2018
@sjenning sjenning requested a review from derekwaynecarr March 21, 2018 18:30
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjenning
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: derekwaynecarr

Assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 21, 2018
@eparis
Copy link
Member

eparis commented Mar 28, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2018
@eparis
Copy link
Member

eparis commented Mar 31, 2018

This 3.9 PR is being closed. Any PR intended to be included in a future openshift enterprise release should be opened in the openshift enterprise repository.

@eparis eparis closed this Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@eparis eparis Awaiting requested review from eparis

Assignees

@derekwaynecarr derekwaynecarr

Labels
kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sjenning @openshift-ci-robot @eparis @derekwaynecarr @openshift-merge-robot