Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] Drop image signature annotations #19078

Conversation

miminar
Copy link

@miminar miminar commented Mar 23, 2018

Backports #19037

Resolves: rhbz#1557607

/assign @bparees

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 23, 2018
@miminar
Copy link
Author

miminar commented Mar 23, 2018

/test

@tnozicka tnozicka removed their request for review March 26, 2018 13:47
@miminar
Copy link
Author

miminar commented Mar 26, 2018

  1. Hosts:    ci-prtest-7ec2229-7-ig-m-j9ch
     Play:     OpenShift Health Checks
     Task:     Run health checks (install) - EL
     Message:  One or more checks failed
     Details:  check "package_version":
               Some required package(s) are available at a version
               that is higher than requested
                 docker-1.13.1
               This will prevent installing the version you requested.
               Please check your enabled repositories or adjust openshift_release.

I suppose origin 3.7 ci/cd is out of interest now. @bparees but we want to merge this anyway, right?

@bparees
Copy link
Contributor

bparees commented Mar 26, 2018

I suppose origin 3.7 ci/cd is out of interest now. @bparees but we want to merge this anyway, right?

generally we don't backport to old origin releases, but this is bad enough it would be nice to have it.

And we certainly need the 3.7 CI working for the things that are important enough to backport, so paging @stevekuznetsov and @paradigm for the CI failure.

@openshift-ci-robot
Copy link

@miminar: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_image_registry 168a59e link /test extended_image_registry
ci/openshift-jenkins/gcp 168a59e link /test gcp
ci/openshift-jenkins/extended_conformance_install 168a59e link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor

bparees commented Mar 27, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, miminar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2018
@bparees
Copy link
Contributor

bparees commented Mar 27, 2018

@miminar let's punt on this backport. it's not the sort of thing we normally backport to 3.7 and the CI system is broken. (If the CI system weren't broken i'd say let's merge it, but I don't want to deal w/ getting this through a broken merge queue)

@smarterclayton how important is having CI work against older origin branches, to you?

@bparees bparees closed this Mar 27, 2018
@miminar
Copy link
Author

miminar commented Mar 28, 2018

understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants