Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cluster capacity from origin repo #19261

Merged
merged 2 commits into from
Apr 11, 2018

Conversation

smarterclayton
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2018
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 7, 2018
@smarterclayton
Copy link
Contributor Author

@derekwaynecarr for when @aveshagarwal's changes merge

@ingvagabund
Copy link
Member

$ grep -rn "cluster-capacity"
hack/lib/constants.sh:179:# cmd/cluster-capacity and doc.go useful for tools that
hack/lib/constants.sh:219:              -o -path '*cmd/cluster-capacity' \
tools/depcheck/examples/origin_excludes.json:4:	"github.com/openshift/origin/cmd/cluster-capacity"
tools/depcheck/pkg/graph/openshift.go:17:		"github.com/openshift/origin/cmd/cluster-capacity",
Binary file .git/objects/pack/pack-c045fc05a193d95e85321a3feb1411a44ae2fc96.pack matches
glide.yaml:3:- cmd/cluster-capacity

hack/lib/constants.sh:179:# cmd/cluster-capacity and doc.go useful for tools that

Just comment

hack/lib/constants.sh:219: -o -path '*cmd/cluster-capacity' \

Has no effect

tools/depcheck/examples/origin_excludes.json:4: "github.com/openshift/origin/cmd/cluster-capacity"

This should be removed

tools/depcheck/pkg/graph/openshift.go:17: "github.com/openshift/origin/cmd/cluster-capacity",

Had no effect

Binary file .git/objects/pack/pack-c045fc05a193d95e85321a3feb1411a44ae2fc96.pack matches
glide.yaml:3:- cmd/cluster-capacity

part of the excludeDirs clause

Given the cluster-capacity is about to be removed completely, we can remove all references of the project so noone is surprised when he/she sees the cluster-capacity keyword.

It's not a blocker for the PR but it could lead to a confusion in the future.

@smarterclayton
Copy link
Contributor Author

I might have snipped those in the follow up but not in here. Will look.

@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/test cmd

@ingvagabund
Copy link
Member

/test extended_conformance_install

@ingvagabund
Copy link
Member

@aveshagarwal feel free to give lgtm

@aveshagarwal
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member

/retest

@ingvagabund
Copy link
Member

/test cmd

@ingvagabund
Copy link
Member

/retest

@ingvagabund
Copy link
Member

/test cmd

@openshift-merge-robot openshift-merge-robot merged commit 335c104 into openshift:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants