UPSTREAM: <carry>: disable local storage isolation feature gate #19323
Conversation
openshift-ci-robot
added
the
size/XS
|
I expected this to be done via the feature-gates argument, not as an upstream carry |
|
@liggitt where would that be done in the code? I don't see an example of this. |
|
also aren't we running the bare kubelet in 3.10? |
|
this needs to be set globally so it is known to apiserver, controller, kubelet. |
|
Ah, I thought it was just kubelet. This is fine for now, then. Do we know when this flag will graduate and be removed or stop being honored? |
|
@liggitt -- can you give a pointer on where we can override this so its applied globally? this looked to me like the right spot, but i am probably behind on the series of refactors. the goal is that the feature gate is off by default, but a customer could turn it on. want to claim the feature as tech preview. |
if we need to change the default across multiple components, this is reasonable |
|
/approve /retest |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Addition of ephemeral storage in the pod spec due to rebase is causing unit test failures. Need to rebase. |
sjenning
force-pushed
the
carry-disable-lsi
branch
from
e0a13e6 to
6a20a0c
Compare
|
/retest |
sjenning
force-pushed
the
carry-disable-lsi
branch
from
6a20a0c to
0cf1574
Compare
openshift-ci-robot
added
size/S
sjenning
force-pushed
the
carry-disable-lsi
branch
from
0cf1574 to
9269438
Compare
openshift-ci-robot
added
size/M
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://trello.com/c/0Omf07Vr/891-3-node-prevent-abuse-of-local-ephemeral-storage
We need more time to evaluate the implications of this feature, especially for Online.