stop using factory.OpenshiftClientConfig #19343
Conversation
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/L
| FromWebhook: server.URL + "/webhook", | ||
| Mapper: legacyscheme.Registry.RESTMapper(), | ||
| } | ||
| if err := o.Run(); err == nil || !strings.Contains(err.Error(), "certificate signed by unknown authority") { |
There was a problem hiding this comment.
This test never actually tested what it claimed to test. It mocked an error from the wrong point to indicate a failure during actual communication. That hook point no longer exists since this was actually a failure during client construction.
There was a problem hiding this comment.
@bparees fyi, your team will need to update it to do what it should be doing.
There was a problem hiding this comment.
i don't think this test ever had any real value (even if it had been implemented correctly). I'm fine w/ losing it.
deads2k
force-pushed
the
cli-28-slim-interface
branch
from
a626721 to
509d6a2
Compare
|
/retest |
1 similar comment
|
/retest |
deads2k
force-pushed
the
cli-28-slim-interface
branch
from
509d6a2 to
6627dc6
Compare
| FromWebhook: server.URL + "/webhook", | ||
| Mapper: legacyscheme.Registry.RESTMapper(), | ||
| } | ||
| if err := o.Run(); err == nil || !strings.Contains(err.Error(), "certificate signed by unknown authority") { |
There was a problem hiding this comment.
@bparees fyi, your team will need to update it to do what it should be doing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This method prevents collapsing onto the upstream factory because it relies on direct kubeconfig access which is hidden/abstracted via a factory.
We've now got a patch to indicate that delta that we carry.
/assign @soltysh
/assign @juanvallejo