Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update oc commands to build their own clients #19345

Merged
merged 1 commit into from
Apr 17, 2018
Merged

update oc commands to build their own clients #19345

merged 1 commit into from
Apr 17, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 13, 2018

In a factory free world, commands build their own clients. This updates commands to build the clients they need based on config. We are moving to a factory free world.

/assign @soltysh
/assign @juanvallejo

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2018
soltysh
soltysh reviewed Apr 16, 2018
View reviewed changes
pkg/oc/cli/util/clientcmd/client.go
@@ -1,193 +0,0 @@
package clientcmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die, die, die 🎉 ❤️ 👍

soltysh
soltysh approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k force-pushed the cli-29-clients-not-factories branch from b033142 to a804b75 Compare April 16, 2018 15:26
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 16, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Apr 16, 2018

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Apr 16, 2018

/retest

@deads2k deads2k force-pushed the cli-29-clients-not-factories branch from a804b75 to 79e30c7 Compare April 16, 2018 18:15
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
@deads2k deads2k force-pushed the cli-29-clients-not-factories branch from 79e30c7 to 5264945 Compare April 16, 2018 19:45
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Apr 17, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Apr 17, 2018

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Apr 17, 2018

/retest

@deads2k deads2k added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Apr 17, 2018

holding to give #19327 priority

@openshift-merge-robot openshift-merge-robot merged commit 5264945 into openshift:master Apr 17, 2018
@deads2k deads2k deleted the cli-29-clients-not-factories branch July 3, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@juanvallejo juanvallejo juanvallejo approved these changes

Assignees

@soltysh soltysh

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deads2k @openshift-ci-robot @openshift-bot @soltysh @juanvallejo @openshift-merge-robot