OpenShift SDN: Improvements to UpdateEgressNetworkPolicyRules() #19346
Conversation
openshift-ci-robot
added
size/L
|
@openshift/sig-networking PTAL |
|
Hm... so had you already written things this way before I pointed you to my ovs-transaction branch? I feel like that way is simpler, and it also has the advantage of automatically improving all uses of ovs-ofctl, without needing any further rewriting... |
Old behavior: 1. Drop outgoing traffic 2. Examine egress np, generate and add ovs flows 3. Enable traffic Step (2) could be slow when egress np has many DNS entries. New behavior: (1) Examine egress np, generate ovs flows (not added) (2) Drop outgoing traffic (3) Add generated ovs flows in (1) (4) Enable traffic
pravisankar
force-pushed
the
egress-dns-fix
branch
from
eac29d5 to
d615f22
Compare
openshift-ci-robot
added
size/S
|
@danwinship Current changes on this pr should unblock #19276 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- With ovs atomic transaction, flows are actually executed when Commit() is called so we no longer need the earlier workaround.
- With ovs atomic transaction, flows are actually executed when Commit() is called so we no longer need the earlier workaround.
- With ovs atomic transaction, flows are actually executed when Commit() is called so we no longer need the earlier workaround.
- With ovs atomic transaction, flows are actually executed when Commit() is called so we no longer need the earlier workaround.
- With ovs atomic transaction, flows are actually executed when Commit() is called so we no longer need the earlier workaround.
- With ovs atomic transaction, flows are actually executed when Commit() is called so we no longer need the earlier workaround.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1558484
Fixes #19276