Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1567532 - Unidle handling in router should ignore headless services #19416

Merged

Conversation

pravisankar
Copy link

  • Currently, service with empty ClusterIP is ignored but headless services
    can have ClusterIP="None" and those need to be ignored as well.

Found this problem on ca-central starter cluster where router reload failed due to incorrect haproxy config:

limiter.go:137] error reloading router: exit status 1
: parsing [/var/lib/haproxy/conf/haproxy.config:63325] : 'server ept:mysql:None:3306' : could not resolve address 'None'.
: Failed to initialize server(s) addr.

None in endpoint.ID came from service.Spec.ClusterIP

- Currently, service with empty ClusterIP is ignored but headless services
can have ClusterIP="None" and those need to be ignored as well.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2018
@pravisankar
Copy link
Author

@openshift/sig-networking PTAL

@pravisankar
Copy link
Author

/retest

@imcsk8
Copy link
Contributor

imcsk8 commented Apr 20, 2018

LGTM

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks Ravi

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 55b4666 into openshift:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/routing lgtm Indicates that a PR is ready to be merged. sig/networking size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants