Override routes from certain domains with the hostname template #19418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Still to add tests but @cldmnky can you please check if this works for you? Thx |
|
Will test it, looks like it will solve our issue! |
ramr
force-pushed
the
override-defaulted-hosts
branch
from
61938aa to
570ef0f
Compare
openshift-ci-robot
added
size/L
ramr
changed the title
|
@ramr It works perfectly for us! Thanks! |
|
flake #19058 |
|
/retest |
|
/test gcp |
ramr
force-pushed
the
override-defaulted-hosts
branch
from
570ef0f to
fdb3458
Compare
|
/test integration |
knobunc
approved these changes
Apr 26, 2018
test/extended/router/scoped.go
Outdated
| @@ -165,6 +165,65 @@ var _ = g.Describe("[Conformance][Area:Networking][Feature:Router]", func() { | |||
| o.Expect(status).To(o.Equal(kapi.ConditionTrue)) | |||
| o.Expect(condition.LastTransitionTime).NotTo(o.BeNil()) | |||
| }) | |||
|
|
|||
| g.It("should override the route host for overriden domains with a custom value", func() { | |||
test/extended/router/scoped.go
Outdated
| execPodName := exutil.CreateExecPodOrFail(oc.AdminKubeClient().CoreV1(), ns, "execpod") | ||
| defer func() { oc.AdminKubeClient().CoreV1().Pods(ns).Delete(execPodName, metav1.NewDeleteOptions(1)) }() | ||
|
|
||
| g.By(fmt.Sprintf("creating a scoped router with overriden domains from a config file %q", configPath)) |
| @@ -104,6 +132,36 @@ objects: | |||
| ports: | |||
| - targetPort: http | |||
|
|
|||
| # routes that contain overriden domains | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, ramr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ramr
force-pushed
the
override-defaulted-hosts
branch
2 times, most recently
from
2bc100a to
de9bf61
Compare
|
@knobunc made the requested changes + squashed the commits. PTAL |
|
/retest |
with the subdomain/hostname-template that the router environment is running under. And fix typos as per @knobunc review Fixes issue openshift#16797
ramr
force-pushed
the
override-defaulted-hosts
branch
from
de9bf61 to
e2b68bc
Compare
|
/test gcp |
|
/lgtm Thanks @ramr |
|
/test gcp |
|
/retest |
|
/test gcp |
|
/test unit |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow routes from certain domains (ala defaulted domains) to be replaced with the subdomain/hostname-template the router environment is running under.
Fixes issue #16797