Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 62733: Set a default request timeout for discovery client #19471

Merged
merged 2 commits into from
May 10, 2018
Merged

UPSTREAM: 62733: Set a default request timeout for discovery client #19471

merged 2 commits into from
May 10, 2018

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 23, 2018

Fixes #17159.

/assign @deads2k

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2018
@soltysh soltysh force-pushed the discovery_timeout branch from d6d5a4c to a42cff0 Compare May 7, 2018 13:19
@deads2k
Copy link
Contributor

deads2k commented May 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2018
@soltysh
Copy link
Contributor Author

soltysh commented May 9, 2018

/retest

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented May 10, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit d6d544e into openshift:master May 10, 2018
@soltysh soltysh deleted the discovery_timeout branch May 10, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@sttts sttts Awaiting requested review from sttts

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soltysh @deads2k @openshift-ci-robot @openshift-merge-robot