Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 62827: fix csi data race in csi_attacher_test.go #19508

Merged
merged 1 commit into from
May 2, 2018

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Apr 25, 2018

xref : #19465

Fixes following error reported from linked PR:

=== RUN   TestAttacherAttach
panic: test timed out after 2m0s

goroutine 8 [running]:
testing.startAlarm.func1()
	/usr/local/go/src/testing/testing.go:1145 +0x139
created by time.goFunc
	/usr/local/go/src/time/sleep.go:170 +0x52

goroutine 1 [chan receive, 2 minutes]:
testing.(*T).Run(0xc42017e0f0, 0x1cf5e2d, 0x12, 0x1d70300, 0xc42050fbe8)
	/usr/local/go/src/testing/testing.go:790 +0x59b
testing.runTests.func1(0xc42017e0f0)
	/usr/local/go/src/testing/testing.go:1004 +0xa8
testing.tRunner(0xc42017e0f0, 0xc42050fd28)
	/usr/local/go/src/testing/testing.go:746 +0x16d
testing.runTests(0xc420168a00, 0x28642e0, 0x17, 0x17, 0xc4200e66c8)
	/usr/local/go/src/testing/testing.go:1002 +0x522
testing.(*M).Run(0xc4203adf20, 0x30)
	/usr/local/go/src/testing/testing.go:921 +0x207
main.main()
	github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/volume/csi/_test/_testmain.go:142 +0x2f1

goroutine 19 [chan receive, 2 minutes]:
github.com/openshift/origin/vendor/github.com/golang/glog.(*loggingT).flushDaemon(0x286fe60)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/golang/glog/glog.go:879 +0xc3
created by github.com/openshift/origin/vendor/github.com/golang/glog.init.0
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/golang/glog/glog.go:410 +0x23b

goroutine 36 [chan send, 2 minutes]:
github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/watch.(*FakeWatcher).Modify(...)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/watch/watch.go:140
github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/volume/csi.TestAttacherAttach(0xc42017e1e0)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/volume/csi/csi_attacher_test.go:162 +0x61f
testing.tRunner(0xc42017e1e0, 0x1d70300)
	/usr/local/go/src/testing/testing.go:746 +0x16d
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:789 +0x569
FAIL	github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/volume/csi	120.096s

/sig storage

cc @childsb @jsafrane

@openshift-ci-robot openshift-ci-robot added sig/storage size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2018
@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2018
@gnufied
Copy link
Member Author

gnufied commented Apr 26, 2018

/retest

@jsafrane
Copy link
Contributor

jsafrane commented May 2, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit b93118a into openshift:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/storage size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants