Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle legacy ungroupified PSP review resources #19542

Conversation

enj
Copy link
Contributor

@enj enj commented Apr 27, 2018

Pluralize SCC Kind for /oapi group map

The Kind name is SecurityContextConstraints, not SecurityContextConstraint.

Signed-off-by: Monis Khan [email protected]


UPSTREAM: <carry>: Add PSP review to /oapi Resources

This allows oc to correctly create the legacy ungroupified variants of these objects.

Bug 1572562

Signed-off-by: Monis Khan [email protected]


Add PSP review kinds to /oapi group map

This allows oc to correctly create the legacy ungroupified variants of these objects.

Bug 1572562

Signed-off-by: Monis Khan [email protected]


/kind bug
/assign @deads2k
@openshift/sig-security @openshift/sig-master
xref #19327

https://bugzilla.redhat.com/show_bug.cgi?id=1572562

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/security sig/master labels Apr 27, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 27, 2018
@deads2k
Copy link
Contributor

deads2k commented Apr 30, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2018
enj added 3 commits April 30, 2018 15:54
The Kind name is SecurityContextConstraints, not
SecurityContextConstraint.

Signed-off-by: Monis Khan <[email protected]>
This allows oc to correctly create the legacy ungroupified variants
of these objects.

Bug 1572562

Signed-off-by: Monis Khan <[email protected]>
This allows oc to correctly create the legacy ungroupified variants
of these objects.

Bug 1572562

Signed-off-by: Monis Khan <[email protected]>
@enj enj force-pushed the enj/i/psp_review_groupified_fix/1572562 branch from a236164 to 6144c4b Compare April 30, 2018 19:56
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2018
@enj
Copy link
Contributor Author

enj commented Apr 30, 2018

Retagging, rebased on master due to conflict.

@enj enj added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 30, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj
Copy link
Contributor Author

enj commented Apr 30, 2018

/retest

Digest: sha256:f35a14509c3c7c9e757c4fff4ea7682b86eecf6e6b5d9952497b8abac259fbb5
Status: Downloaded newer image for registry.svc.ci.openshift.org/ci/clonerefs:latest
+ break
+ for image in ''\''registry.svc.ci.openshift.org/ci/clonerefs:latest'\''' ''\''registry.svc.ci.openshift.org/ci/initupload:latest'\'''
+ (( i = 0 ))
+ (( i < 5 ))
+ docker pull registry.svc.ci.openshift.org/ci/initupload:latest
Trying to pull repository registry.svc.ci.openshift.org/ci/initupload ... 
latest: Pulling from registry.svc.ci.openshift.org/ci/initupload
6d987f6f4279: Already exists
4cccebe844ee: Already exists
762dc6f69cc5: Pulling fs layer
762dc6f69cc5: Verifying Checksum
762dc6f69cc5: Download complete
762dc6f69cc5: Pull complete
Digest: sha256:6736649f898792ccab7b2a33db5c7b0c05f56bef892c3fc1077e708cdc93f8e5
Status: Downloaded newer image for registry.svc.ci.openshift.org/ci/initupload:latest
+ break
+ clonerefs_args=
+ docker run -e 'JOB_SPEC={"type":"presubmit","job":"test_pull_request_origin_unit","buildid":"12580","refs":{"org":"openshift","repo":"origin","base_ref":"master","base_sha":"0b74dfc55d341566ad1469f99d886eb82545756a","pulls":[{"number":19542,"author":"enj","sha":"6144c4bac363e815c965763ed87090eb8ecf7b87"}]}}' -v /data:/data:z registry.svc.ci.openshift.org/ci/clonerefs:latest --src-root=/data --log=/data/clone.json
time="2018-04-30T19:58:51Z" level=fatal msg="Invalid options: no refs specified to clone" 
++ export status=FAILURE
++ status=FAILURE
+ set +o xtrace
########## FINISHED STAGE: FAILURE: SYNC REPOSITORIES [00h 00m 33s] ##########
Build step 'Execute shell' marked build as failure

@enj
Copy link
Contributor Author

enj commented May 1, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 95c5c16 into openshift:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. sig/master sig/security size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants