-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly handle legacy ungroupified PSP review resources #19542
Correctly handle legacy ungroupified PSP review resources #19542
Conversation
/lgtm |
The Kind name is SecurityContextConstraints, not SecurityContextConstraint. Signed-off-by: Monis Khan <[email protected]>
This allows oc to correctly create the legacy ungroupified variants of these objects. Bug 1572562 Signed-off-by: Monis Khan <[email protected]>
This allows oc to correctly create the legacy ungroupified variants of these objects. Bug 1572562 Signed-off-by: Monis Khan <[email protected]>
a236164
to
6144c4b
Compare
New changes are detected. LGTM label has been removed. |
Retagging, rebased on master due to conflict. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest
|
/retest |
Pluralize SCC Kind for /oapi group map
The Kind name is SecurityContextConstraints, not SecurityContextConstraint.
Signed-off-by: Monis Khan [email protected]
UPSTREAM:
<carry>
: Add PSP review to /oapi ResourcesThis allows oc to correctly create the legacy ungroupified variants of these objects.
Bug 1572562
Signed-off-by: Monis Khan [email protected]
Add PSP review kinds to /oapi group map
This allows oc to correctly create the legacy ungroupified variants of these objects.
Bug 1572562
Signed-off-by: Monis Khan [email protected]
/kind bug
/assign @deads2k
@openshift/sig-security @openshift/sig-master
xref #19327
https://bugzilla.redhat.com/show_bug.cgi?id=1572562