Bug 1572179 - Remove openvswitch check from UnitStatus diagnostic #19572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/S
pravisankar
added
component/diagnostics
and removed
size/S
|
@knobunc @sosiouxme PTAL |
pravisankar
added
the
size/S
|
/lgtm |
|
/lgtm Thanks @pravisankar. But is there any other check we should do now OVS is containerized? |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
On Wed, May 2, 2018 at 8:38 AM, Ben Bennett ***@***.***> wrote:
/lgtm
Thanks @pravisankar <https://github.com/pravisankar>. But is there any
other check we should do now OVS is containerized?
I do not think there is a check for containerized OVS. Since this is no
longer a unit file, at least it can not be part of unitstatus diagnostic.
OVS component is internal implementation details of openshift sdn and sdn
will not start if ovs is not available. So we may not need this explicit
check.
—
… You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19572 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABM0htSE1gIGjBLpWSGexADpCaLDt9ibks5tudL3gaJpZM4TtVEv>
.
|
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
- For openshift version >= 3.10, openvswitch on the node will be run as a daemonset so it won't appear on node systemd units.
pravisankar
force-pushed
the
fix-diag-unitstatus
branch
from
61cfdb2 to
c4082b6
Compare
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it won't appear on node systemd units.