UPSTREAM: 63926: Avoid unnecessary calls to the cloud provider #19742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the service controller is processing a service that does not have type LoadBalancer and does not have any external load balancer recorded in its status, do not call the cloud provider to check for an associated load balancer. This commit fixes bug 1571940. https://bugzilla.redhat.com/show_bug.cgi?id=1571940
openshift-ci-robot
added
the
size/XS
|
/assign @derekwaynecarr |
|
@derekwaynecarr @smarterclayton @deads2k -- Can you please take a look at this so we can get it onto starter to see if we can reduce the API calls we are making? Thanks |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, knobunc, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Miciah
added a commit
to Miciah/origin
that referenced
this pull request
Jun 27, 2018
If the service controller is processing a service that does not have type LoadBalancer and does not have any external load balancer recorded in its status, do not call the cloud provider to check for an associated load balancer. This commit fixes bug 1583718. https://bugzilla.redhat.com/show_bug.cgi?id=1583718 This is a manual cherry-pick of openshift#19742.
soltysh
pushed a commit
to soltysh/origin
that referenced
this pull request
Oct 3, 2019
If the service controller is processing a service that does not have type LoadBalancer and does not have any external load balancer recorded in its status, do not call the cloud provider to check for an associated load balancer. This commit fixes bug 1583718. https://bugzilla.redhat.com/show_bug.cgi?id=1583718 This is a manual cherry-pick of openshift#19742.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the service controller is processing a service that does not have type LoadBalancer and does not have any external load balancer recorded in its status, do not call the cloud provider to check for an associated load balancer.
This commit fixes bug 1571940.
https://bugzilla.redhat.com/show_bug.cgi?id=1571940
Note for backporting:
createLoadBalancersIfNeededin 3.9 returns two arguments, so thereturn nilwill need to be amended asreturn nil, notRetryablein any backport to 3.9.