Use dns go bindings instead of dig command for dns resolution in egress network policy #19805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 22, 2018 01:50
…ss network policy - Query all nameservers in /etc/resolv.conf to populate ovs rules for domain names in egress policy When the given domain is using DNS load balancing algorithm, depending on which nameserver it queries, we may get different IP addr.
- DNS go library is used instead of dig shell command.
- bind-utils pkg was added for 'dig' command and we no longer depend on this command for dns resolution.
openshift-ci-robot
added
the
size/L
|
@openshift/sig-networking @knobunc @danwinship @smarterclayton PTAL |
|
/retest |
|
@smarterclayton can you approve this please if you find it acceptable? Thanks |
|
/retest |
|
I don't have any objection to this, if Ben is fine with this for 3.10 so am
I.
…On Tue, May 22, 2018 at 2:26 PM, OpenShift CI Robot < ***@***.***> wrote:
@pravisankar <https://github.com/pravisankar>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/extended_clusterup aac3da0
<aac3da0>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19805/test_pull_request_origin_extended_clusterup/1547/> /test
extended_clusterup
Full PR test history <https://openshift-gce-devel.appspot.com/pr/19805>. Your
PR dashboard <https://openshift-gce-devel.appspot.com/pr/pravisankar>.
Please help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/origin/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/devel/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19805 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p5Eo5HLruQCIAPnuaeZ19MqaPY0Sks5t1FhigaJpZM4UI813>
.
|
|
@smarterclayton I am fine with it for 3.10. I've approved it, but can't approve the change to origin.spec. |
|
/approve
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, pravisankar, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes bug: https://bugzilla.redhat.com/show_bug.cgi?id=1575583