install ceph-common in control plane so rbd provisioner can find rbd cli to create rbd images #19870

rootfs · 2018-05-29T17:39:08Z

fix https://bugzilla.redhat.com/show_bug.cgi?id=1582059

sdodson · 2018-05-29T17:44:48Z

/approve
/lgtm

openshift-bot · 2018-05-29T18:38:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

smarterclayton · 2018-05-29T20:19:39Z

/hold

…

On Tue, May 29, 2018 at 2:40 PM, OpenShift CI Robot < ***@***.***> wrote: @rootfs <https://github.com/rootfs>: The following test *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/gcp 314b654 <314b654> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19870/test_pull_request_origin_extended_conformance_gce/20846/> /test gcp Full PR test history <https://openshift-gce-devel.appspot.com/pr/19870>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/rootfs>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#19870 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p60iJbIBe5Jhis40cMHSxwi4RS3Nks5t3ZYcgaJpZM4UR7T_> .

smarterclayton · 2018-05-29T20:20:42Z

images/node/Dockerfile

@@ -16,14 +16,12 @@ COPY system-container/manifest.json system-container/config.json.template system
 RUN INSTALL_PKGS=" \
      origin-hyperkube origin-node origin-sdn-ovs \
      socat ethtool device-mapper iptables nmap-ncat e2fsprogs \
-      xfsprogs device-mapper-persistent-data ceph-common \
+      xfsprogs device-mapper-persistent-data\


Why did you remove this here?

Because node is FROM openshift/origin-control-plane

It has to remain here. Node image won’t depend on control plane next release

smarterclayton · 2018-05-29T20:21:13Z

images/origin/Dockerfile

@@ -6,7 +6,9 @@
 #
 FROM openshift/origin-cli

-RUN INSTALL_PKGS="origin" && \
+RUN INSTALL_PKGS="origin ceph-common" && \


Is this only used by the controllers?

It's used by controller-manager for dynamic provisioning and resize and by kubelet to map/unmap (local "attach"/"detach") volumes.

rootfs · 2018-06-15T12:48:24Z

@smarterclayton @childsb yes we need ceph-common to pick up rbd command for controller to provision and resize rbd images.

smarterclayton · 2018-06-15T13:48:57Z

images/node/Dockerfile

@@ -16,14 +16,12 @@ COPY system-container/manifest.json system-container/config.json.template system
 RUN INSTALL_PKGS=" \
      origin-hyperkube origin-node origin-sdn-ovs \
      socat ethtool device-mapper iptables nmap-ncat e2fsprogs \
-      xfsprogs device-mapper-persistent-data ceph-common \
+      xfsprogs device-mapper-persistent-data\


It has to remain here. Node image won’t depend on control plane next release

rootfs · 2018-06-21T13:35:20Z

@sdodson @smarterclayton thanks, review addressed.

cc @bertinatto

smarterclayton · 2018-06-21T13:38:18Z

images/node/Dockerfile

      libmnl libnetfilter_conntrack conntrack-tools \
      libnfnetlink iproute bridge-utils procps-ng openssl \
      binutils xz kmod-libs kmod sysvinit-tools device-mapper-libs dbus \
      iscsi-initiator-utils \
      " && \
-    yum install -y centos-release-ceph-luminous && \
-    rpm -V centos-release-ceph-luminous && \


You need to still install this here if it isn’t already. You should remove all changes to this file.

rootfs · 2018-06-21T15:25:41Z

@smarterclayton thanks, updated, PTAL

smarterclayton · 2018-06-21T16:04:23Z

/lgtm
/approve
/cherry-pick release-3.10

jsafrane · 2018-06-21T16:32:21Z

@rootfs, can you please squash the commits?

…cli to create rbd images Signed-off-by: Huamin Chen <[email protected]>

rootfs · 2018-06-21T17:00:41Z

@jsafrane squashed

jsafrane · 2018-06-21T17:05:48Z

/lgtm
/hold cancel

openshift-ci-robot · 2018-06-21T17:05:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rootfs, sdodson, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~images/origin/OWNERS~~ [sdodson,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bertinatto · 2018-06-21T18:36:26Z

/retest

smarterclayton · 2018-06-21T21:24:26Z

/retest

sdodson · 2018-06-22T12:17:30Z

/cherrypick release-3.10

rootfs requested review from sdodson, smarterclayton and 0xmichalis May 29, 2018 17:39

openshift-ci-robot requested a review from dcbw May 29, 2018 17:39

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 29, 2018

openshift-ci-robot assigned sdodson May 29, 2018

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2018

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2018

smarterclayton reviewed May 29, 2018

View reviewed changes

smarterclayton suggested changes Jun 15, 2018

View reviewed changes

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2018

smarterclayton suggested changes Jun 21, 2018

View reviewed changes

rootfs force-pushed the rbd-img-control-plane branch from 73e84ce to 77a396c Compare June 21, 2018 15:23

openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2018

rootfs force-pushed the rbd-img-control-plane branch from 77a396c to 4d2a0a1 Compare June 21, 2018 15:25

openshift-ci-robot assigned smarterclayton Jun 21, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2018

install ceph-common in control plane so rbd provisioner can find rbd …

f65605a

…cli to create rbd images Signed-off-by: Huamin Chen <[email protected]>

rootfs force-pushed the rbd-img-control-plane branch from 4d2a0a1 to f65605a Compare June 21, 2018 17:00

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2018

openshift-ci-robot assigned jsafrane Jun 21, 2018

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 21, 2018

openshift-merge-robot merged commit 67a36ff into openshift:master Jun 21, 2018

wongma7 mentioned this pull request Jul 5, 2018

install ceph-common in control plane so rbd provisioner can find rbd … #20222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

install ceph-common in control plane so rbd provisioner can find rbd cli to create rbd images #19870

install ceph-common in control plane so rbd provisioner can find rbd cli to create rbd images #19870

rootfs commented May 29, 2018

sdodson commented May 29, 2018

openshift-bot commented May 29, 2018

smarterclayton commented May 29, 2018 via email

smarterclayton May 29, 2018

sdodson May 29, 2018

smarterclayton Jun 15, 2018

smarterclayton May 29, 2018

jsafrane Jun 14, 2018

rootfs commented Jun 15, 2018

smarterclayton Jun 15, 2018

rootfs commented Jun 21, 2018

smarterclayton Jun 21, 2018

rootfs commented Jun 21, 2018

smarterclayton commented Jun 21, 2018

jsafrane commented Jun 21, 2018

rootfs commented Jun 21, 2018

jsafrane commented Jun 21, 2018

openshift-ci-robot commented Jun 21, 2018

bertinatto commented Jun 21, 2018

smarterclayton commented Jun 21, 2018

sdodson commented Jun 22, 2018

install ceph-common in control plane so rbd provisioner can find rbd cli to create rbd images #19870

install ceph-common in control plane so rbd provisioner can find rbd cli to create rbd images #19870

Conversation

rootfs commented May 29, 2018

sdodson commented May 29, 2018

openshift-bot commented May 29, 2018

smarterclayton commented May 29, 2018 via email

smarterclayton May 29, 2018

Choose a reason for hiding this comment

sdodson May 29, 2018

Choose a reason for hiding this comment

smarterclayton Jun 15, 2018

Choose a reason for hiding this comment

smarterclayton May 29, 2018

Choose a reason for hiding this comment

jsafrane Jun 14, 2018

Choose a reason for hiding this comment

rootfs commented Jun 15, 2018

smarterclayton Jun 15, 2018

Choose a reason for hiding this comment

rootfs commented Jun 21, 2018

smarterclayton Jun 21, 2018

Choose a reason for hiding this comment

rootfs commented Jun 21, 2018

smarterclayton commented Jun 21, 2018

jsafrane commented Jun 21, 2018

rootfs commented Jun 21, 2018

jsafrane commented Jun 21, 2018

openshift-ci-robot commented Jun 21, 2018

bertinatto commented Jun 21, 2018

smarterclayton commented Jun 21, 2018

sdodson commented Jun 22, 2018