Allow egress-router to connect to its own node IP, for DNS, etc #19885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwinship
added
kind/bug
openshift-ci-robot
added
approved
|
/retest |
danwinship
force-pushed
the
egress-router-dns-routing
branch
from
7a6ed5e to
f782553
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, knobunc, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
pravisankar
pushed a commit
to pravisankar/origin
that referenced
this pull request
Jun 25, 2018
openshift#19885 allows egress routers to connect to the node IP but when openshift node is configured to use service network IP as DNS IP then egress router pod will not be able to resolve DNS requests. This change will address this issue.
pravisankar
pushed a commit
to pravisankar/origin
that referenced
this pull request
Jun 25, 2018
openshift#19885 allows egress routers to connect to the node IP but when openshift node is configured to use service network IP as DNS IP then egress router pod will not be able to resolve DNS requests. This change will address this issue.
pravisankar
pushed a commit
to pravisankar/origin
that referenced
this pull request
Jun 25, 2018
openshift#19885 allows egress routers to connect to the node IP but when openshift node is configured to use service network IP as DNS IP then egress router pod will not be able to resolve DNS requests. This change will address this issue.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/origin
that referenced
this pull request
Jun 26, 2018
openshift#19885 allows egress routers to connect to the node IP but when openshift node is configured to use service network IP as DNS IP then egress router pod will not be able to resolve DNS requests. This change will address this issue.
deads2k
pushed a commit
to openshift/sdn
that referenced
this pull request
Jun 18, 2019
openshift/origin#19885 allows egress routers to connect to the node IP but when openshift node is configured to use service network IP as DNS IP then egress router pod will not be able to resolve DNS requests. This change will address this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Egress routers can't currently connect to their own node, because they try to do it via the macvlan, and macvlans are never able to reach their parent interface, regardless of configuration options. This fixes it so that egress-router-to-node-IP traffic gets routed via the SDN instead. This also requires a fix to the egress-router iptables NAT rules, which were being overzealous before.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552738