move controller SA to openshift-system

[deads2k]

Let's just see if this works.

@openshift/sig-storage is there good coverage of the recycler? This is moving it to use a different SA and namespace. Why do you use SCC, do you really want to?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

integration and unit tests would be fairly easy to clean up.

/assign @liggitt

[deads2k]

@liggitt ready to review. I think I fixed up the unit and integration tests.

/retest

[mfojtik]

missing error handling

[jsafrane]

is there good coverage of the recycler?

No, Origin does not run any (or very little) upstream storage tests. See #18816

This is moving it to use a different SA and namespace.

Ok,

Why do you use SCC, do you really want to?

Heh, this is really ancient code, it has been like that since forever. What do other controllers use?

BTW, IMO it's better to postpone this to 3.11 (and enable upstream tests).

[liggitt]

metrics is moving out of openshift-infra in openshift/openshift-ansible#8649

if that is the extent of the supported applications we run in openshift-infra, then I'm cautiously in favor of closing this PR and leaving openshift-infra without openshift-dependent admission plugins running on it.

That does require a prominent release note reiterating the nature of openshift-infra and indicating that user-deployed applications should not be placed in that namespace.