Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server-side column printer support for openshift objects #19934

Merged
merged 5 commits into from
Jun 8, 2018
Merged

Add server-side column printer support for openshift objects #19934

merged 5 commits into from
Jun 8, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 7, 2018

We never hooked up openshift storage to act as table printers to support server-side printing in 3.10

If we want to drop client-side printing in 3.11, this is required.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Jun 7, 2018

@liggitt
Copy link
Contributor Author

liggitt commented Jun 7, 2018

@openshift/sig-master

@smarterclayton
Copy link
Contributor

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 008e50d into openshift:master Jun 8, 2018
@liggitt liggitt deleted the column-printers branch June 11, 2018 04:39
@soltysh
Copy link
Contributor

soltysh commented Jun 13, 2018

If we want to drop client-side printing in 3.11, this is required.

We're not dropping it, we're just enabling it by default in 3.11, but still leave the functionality in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/cli component/restapi lgtm Indicates that a PR is ready to be merged. sig/master size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants