Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Egress DNS: Get lowest TTL from the dns resolution chain #19982

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Egress DNS: Get lowest TTL from the dns resolution chain #19982

merged 2 commits into from
Jun 14, 2018

Conversation

pravisankar
Copy link

  • Currently, we consider minTTL as lowest TTL among all available dns
    'A' records and TTL for CNAME recs are ignored. This change will get
    lowest TTL for the entire chain irrespective of the dns record type.

Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=1575583

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2018
@pravisankar
Copy link
Author

@openshift/sig-networking @knobunc PTAL

@pravisankar pravisankar requested a review from knobunc June 12, 2018 17:50
knobunc
knobunc approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks Ravi.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2018
@pravisankar
Copy link
Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Egress DNS: Get lowest TTL from the dns resolution chain
fc18c00 
- Currently, we consider minTTL as lowest TTL among all available dns
'A' records and TTL for CNAME recs are ignored. This change will get
lowest TTL for the entire chain irrespective of the dns record type.
Increased DNS request timeout from 2 secs to 5 secs
abcc7f6 
- Noticed 2 seconds was not enough in some cases.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2018
@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pravisankar
Copy link
Author

/retest

2 similar comments
@pravisankar
Copy link
Author

/retest

@pravisankar
Copy link
Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e9d50ca into openshift:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@danwinship danwinship Awaiting requested review from danwinship

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@danwinship danwinship

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/networking size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pravisankar @openshift-bot @danwinship @openshift-ci-robot @knobunc @openshift-merge-robot