Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable batch/v2alpha1 API groupversion #19996

Merged
merged 3 commits into from
Jun 14, 2018
Merged

Disable batch/v2alpha1 API groupversion #19996

merged 3 commits into from
Jun 14, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 13, 2018

We do not serve alpha APIs by default.

If required, they can be re-enabled with this config:

kubernetesMasterConfig:
  apiServerArguments:
    ...
    runtime-config:
    - apis/batch/v2alpha1=true

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Jun 13, 2018

/cc @deads2k @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2018
@liggitt liggitt added this to the v3.10 milestone Jun 14, 2018
liggitt
liggitt commented Jun 14, 2018
View reviewed changes
vendor/k8s.io/kubernetes/pkg/kubectl/resource/builder.go
@@ -219,6 +220,8 @@ func (b *Builder) LocalParam(local bool) *Builder {
func (b *Builder) Local() *Builder {
mapper := *b.mapper
mapper.ClientMapper = DisabledClientForMapping{ClientMapper: mapper.ClientMapper}
// use the compiled in mappings, and tolerate unknown mappings
mapper.RESTMapper = NewRelaxedRESTMapper(legacyscheme.Registry.RESTMapper())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k this was fun... without this, oc convert fails if the version you are converting from is not served by the server, despite setting Local() on the builder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It should be fixable in 3.11

@liggitt
Copy link
Contributor Author

liggitt commented Jun 14, 2018

/retest

1 similar comment
@liggitt
Copy link
Contributor Author

liggitt commented Jun 14, 2018

/retest

@soltysh
Copy link
Contributor

soltysh commented Jun 14, 2018

We do not serve alpha APIs by default.

Except for batch/v2alpha1 because of cronjobs. But since batch/v1beta1 is present since 3.9 this is ok.

soltysh
soltysh approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9d78c24 into openshift:master Jun 14, 2018
@liggitt liggitt deleted the disable-batch-v2alpha1 branch June 14, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@enj enj Awaiting requested review from enj

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v3.10
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @soltysh @openshift-ci-robot @openshift-bot @deads2k @openshift-merge-robot