Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default image paths used in network diagnostics #20013

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Fix default image paths used in network diagnostics #20013

merged 1 commit into from
Jun 15, 2018

Conversation

pravisankar
Copy link

  • In case of OCP, generated defaults for 3.10 release:
    --pod-image=registry.access.redhat.com/openshift3/ose-control-plane:v3.10
    --test-pod-image=registry.access.redhat.com/openshift3/ose-deployer:v3.10

  • In case of origin, generated defaults for 3.10 release:
    --pod-image=openshift/origin-control-plane:v3.10
    --test-pod-image=openshift/origin-deployer:v3.10

  • For testing on AWS, user need to manually pass the image params
    --pod-image=registry.reg-aws.openshift.com:443/openshift3/ose-control-plane:v3.10
    --test-pod-image=docker.io/openshift/hello-openshift

Fix default image paths used in network diagnostics
46e541b 
 - In case of OCP, generated defaults for 3.10 release:
   --pod-image=registry.access.redhat.com/openshift3/ose-control-plane:v3.10
   --test-pod-image=registry.access.redhat.com/openshift3/ose-deployer:v3.10

 - In case of origin, generated defaults for 3.10 release:
   --pod-image=openshift/origin-control-plane:v3.10
   --test-pod-image=openshift/origin-deployer:v3.10

 - For testing on AWS, user need to manually pass the image params
   --pod-image=registry.reg-aws.openshift.com:443/openshift3/ose-control-plane:v3.10
   --test-pod-image=docker.io/openshift/hello-openshift
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2018
@pravisankar
Copy link
Author

Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=1572182

@pravisankar
Copy link
Author

@sosiouxme @knobunc @ironcladlou PTAL

knobunc
knobunc approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks Ravi.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knobunc
Copy link
Contributor

knobunc commented Jun 15, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pravisankar
Copy link
Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 40e393c into openshift:master Jun 15, 2018
@pravisankar
Copy link
Author

/cherrypick release-3.10

@openshift-cherrypick-robot
Copy link

@pravisankar: new pull request created: #20116

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@jcantrill jcantrill Awaiting requested review from jcantrill

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@sosiouxme sosiouxme Awaiting requested review from sosiouxme

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/diagnostics lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pravisankar @openshift-ci-robot @knobunc @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot