Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free the item from the taint manager workqueue when done #20068

Closed
wants to merge 1 commit into from
Closed

Free the item from the taint manager workqueue when done #20068

wants to merge 1 commit into from

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 21, 2018

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1588244

This fixes a clear leak that left objects in the workqueue "processing" map.

Will open a follow up to make the workqueue key more efficient.

/cc @mfojtik

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Jun 21, 2018

/cherrypick release-3.10

@openshift-cherrypick-robot

@liggitt: once the present PR merges, I will cherry-pick it on top of 3.10 in a new PR and assign it to you.

In response to this:

/cherrypick 3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Contributor Author

liggitt commented Jun 22, 2018

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Jun 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik mfojtik added queue/critical-fix priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 22, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Jun 22, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@liggitt
Copy link
Contributor Author

liggitt commented Jun 22, 2018

/hold

It's unclear whether we want to continue picking upstream changes into master ahead of the rebase. Holding this for now, will test and merge the PR against the 3.10 branch

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2018
@liggitt liggitt added this to the v3.11 milestone Jun 22, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Jun 22, 2018

proceeding with #20071 for 3.10. will leave this open, but hold for the rebase (and will actually pick this fix up in a 1.11.0 rebase)

@openshift-bot
Copy link
Contributor

@liggitt: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2018
@liggitt liggitt closed this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. queue/critical-fix size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants