-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free the item from the taint manager workqueue when done #20068
Conversation
/cherrypick release-3.10 |
@liggitt: once the present PR merges, I will cherry-pick it on top of 3.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold It's unclear whether we want to continue picking upstream changes into master ahead of the rebase. Holding this for now, will test and merge the PR against the 3.10 branch |
proceeding with #20071 for 3.10. will leave this open, but hold for the rebase (and will actually pick this fix up in a 1.11.0 rebase) |
@liggitt: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1588244
This fixes a clear leak that left objects in the workqueue "processing" map.
Will open a follow up to make the workqueue key more efficient.
/cc @mfojtik