Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --read-only opt to oc set volumes #20083

Closed
wants to merge 1 commit into from
Closed

add --read-only opt to oc set volumes #20083

wants to merge 1 commit into from

Conversation

juanvallejo
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/add-read-only-opt branch from c8d4c8d to b485bc3 Compare June 22, 2018 20:28
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2018
@juanvallejo juanvallejo force-pushed the jvallejo/add-read-only-opt branch from b485bc3 to 2b50201 Compare June 22, 2018 20:41
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2018
@juanvallejo
Copy link
Contributor Author

/retest

1 similar comment
@juanvallejo
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor

/test integration
/test verify

soltysh
soltysh approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
let's wait until after the rebase, then feel free to unhold this

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2018
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2018
@juanvallejo
Copy link
Contributor Author

@soltysh removing hold on this as rebase has landed.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2018
@soltysh
Copy link
Contributor

soltysh commented Jul 2, 2018

You are aware you're going to destroy my PR with this 😝

@soltysh
Copy link
Contributor

soltysh commented Jul 3, 2018

/retest

@juanvallejo
Copy link
Contributor Author

/test cmd

@soltysh
Copy link
Contributor

soltysh commented Jul 4, 2018

/retest

1 similar comment
@soltysh
Copy link
Contributor

soltysh commented Jul 4, 2018

/retest

@soltysh soltysh mentioned this pull request Jul 4, 2018
Merged
@soltysh
Copy link
Contributor

soltysh commented Jul 4, 2018

/retest

1 similar comment
@soltysh
Copy link
Contributor

soltysh commented Jul 5, 2018

/retest

@soltysh
Copy link
Contributor

soltysh commented Jul 5, 2018

For some unknown to me reason this hangs constantly on: when creating a project to test test/cmd/secrets.sh. I'm cherry-picking this into #20139 and I'll re-run tests and try to merge there.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2018
@openshift-ci-robot
Copy link

@juanvallejo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 2b50201 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

@juanvallejo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2018
@juanvallejo
Copy link
Contributor Author

Closing. This merged as part of #20139

@juanvallejo juanvallejo closed this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@enj enj Awaiting requested review from enj

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanvallejo @smarterclayton @openshift-ci-robot @soltysh @openshift-bot