Bind mount /etc/origin/kubelet-plugins for flex volumes

[gnufied]

This goes hand-in-hand with openshift/openshift-ansible#8964 for fixing flex volume plugin when kubelet runs as system container.

We will have to cherry-pick this to 3.10 too.

cc @jsafrane
/sig storage

[jsafrane]

/retest

[gnufied]

/assign @sdodson @smarterclayton

[smarterclayton]

This should be under node (if it’s truly kubelet specific). And should probably be /etc/origin/node/plugins On Jun 26, 2018, at 1:36 PM, Hemant Kumar <[email protected]> wrote: /assign @sdodson <https://github.com/sdodson> @smarterclayton <https://github.com/smarterclayton> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20095 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_pzC9S5CuZrmaWnF88pdOQOQnAie4ks5uAnEagaJpZM4U3FRi> .

[gnufied]

@smarterclayton The location I chose to match the default location for flex volumes as documented - https://docs.openshift.com/container-platform/3.9/install_config/persistent_storage/persistent_storage_flex_volume.html

I think it is bit of unfortunate side effect that plugin directory is still called kubelet-plugins even though for flex plugins that support attach/detach - it must be available from same location in controller-manager too.

[smarterclayton]

Ok. Thats' fine.

[avysk]

@gnufied If I may ask -- the documentation you link to gives /usr/libexec/kubernetes/kubelet-plugins as the path for plugins, not /etc/origin/kubelet-plugins. Do I miss something?

[gnufied]

@avysk That currently documents flexvolume installation in non-containarized installation of openshift 3.9.

In Openshift-3.10, since we are moving to all control-plane components running as static pods and on atomic hosts kubelet running as a system container, the document needs to be updated to reflect the correct behaviour.

[sdodson]

/skip

[sdodson]

/retest

[sdodson]

/lgtm

[sdodson]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• images/node/OWNERS [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gnufied]

/test unit
/test gcp

[openshift-ci-robot]

@gnufied: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/unit	d6759b8	link	/test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdodson]

There's no way that this change is breaking those tests. This is a 3.10 blocker, merging.

[sdodson]

/cherrypick release-3.10

[openshift-cherrypick-robot]

@sdodson: new pull request created: #20153

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.