Honor --kubelet-preferred-address-types

[liggitt]

constructs the kubelet client config prior to parsing api server arguments, and uses the resulting struct to build the kubelet client

[liggitt]

/cherrypick release-3.10

[openshift-cherrypick-robot]

@liggitt: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jim-minter]

/retest

[ericavonb]

@liggitt I've tried my best following all the code paths to make sure there aren't any unintended side effects and it seemed ok, but that config code is pretty convoluted so I'm not super confident. Are there any tests that could be added to illuminate why this change is necessary and where it changes behavior?

[liggitt]

Are there any tests that could be added to illuminate why this change is necessary and where it changes behavior?

For most kube-apiserver settings, we follow this pattern:

1. start with default kube-apiserver config structs
2. override specific values with data read from our master-config.yaml fields
3. parse kube-apiserver flags specified in our master-config.yaml (this lets us support almost all flag-driven kube-apiserver functions transparently)

our kubelet config options were not being handled that way. this PR changes them to be handled consistently.

[jim-minter]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jim-minter, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cmd/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[0xmichalis]

/retest

conformance_install failed on a service catalog ansible install error that seems unrelated

[liggitt]

/retest

[0xmichalis]

/retest

[openshift-cherrypick-robot]

@liggitt: new pull request created: #20183

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.