Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(*): Pick up latest image builder #20248

Closed

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jul 8, 2018

Imagebuilder had a serious bug with COPY a /a

@liggitt did we change something about how glide works? I got a billion new dependencies...

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 8, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 8, 2018

@smarterclayton: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 5eb62b6 link /test extended_conformance_install
ci/openshift-jenkins/end_to_end 5eb62b6 link /test end_to_end
ci/openshift-jenkins/extended_clusterup 5eb62b6 link /test extended_clusterup
ci/openshift-jenkins/gcp 5eb62b6 link /test gcp
ci/prow/unit 5eb62b6 link /test unit
ci/openshift-jenkins/cross 5eb62b6 link /test cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Jul 9, 2018

opened the much more constrained #20256.

We really need to move pkg/build/builders out and then when deps shift like this it will be far less conflicty with origin.

@deads2k deads2k closed this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants