make the template processing more compatible with the dynamic client #20337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
mfojtik
reviewed
Jul 17, 2018
|
|
||
| func (c *dynamicTemplateProcessor) ProcessToListFromUnstructured(unstructuredTemplate *unstructured.Unstructured) (*unstructured.UnstructuredList, error) { | ||
| processedTemplate, err := c.client.Resource(templatev1.GroupVersion.WithResource("processedtemplates")). | ||
| Namespace("default").Create(unstructuredTemplate) |
There was a problem hiding this comment.
can you check the error here?
mfojtik
reviewed
Jul 17, 2018
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return processedList, nil |
There was a problem hiding this comment.
i would just return processedTemplate.ToList()
mfojtik
reviewed
Jul 17, 2018
| } | ||
| processedList, err := processedTemplate.ToList() | ||
| templateProcessor := templateprocessing.NewDynamicTemplateProcessor(r.client) | ||
| processedList, err := templateProcessor.ProcessToList(template) |
There was a problem hiding this comment.
nit: templateprocessing.NewDynamicTemplateProcessor(r.client).ProcessToList(template) but I don't care much
mfojtik
reviewed
Jul 17, 2018
| @@ -453,3 +434,13 @@ func TestProcessTemplateParameters(t *testing.T) { | |||
| t.Errorf("unexpected output: %s", diff.StringDiff(string(exp), string(result))) | |||
| } | |||
| } | |||
|
|
|||
| // AddParameter adds new custom parameter to the Template. It overrides | |||
|
@deads2k small nits, LGTM otherwise |
deads2k
force-pushed
the
rebase-07-tempalte
branch
from
62b2b10 to
ad79c88
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
force-pushed
the
rebase-07-tempalte
branch
from
ad79c88 to
183823b
Compare
|
comments addressed. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify processing a template via the API and getting a result you can use with dynamic client.
post-rebase request from @mfojtik
/assign @mfojtik