Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick cloud resource sync manager related fixes. #20370

Closed
wants to merge 2 commits into from
Closed

Pick cloud resource sync manager related fixes. #20370

wants to merge 2 commits into from

Conversation

aveshagarwal
Copy link
Contributor

@aveshagarwal
UPSTREAM: 65226: Store the latest cloud provider node addresses.
9bd7468
@aveshagarwal
UPSTREAM: 66350: Start cloudResourceSyncsManager before getNodeAnyWay…
0923660 
… (initializeModules) to avoid kubelet getting stuck in retrieving node addresses from a cloudprovider.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2018
@aveshagarwal
Copy link
Contributor Author

/test extended_conformance_install
/test end_to_end

@aveshagarwal
Copy link
Contributor Author

It shows:

No Test Failures!

/test gcp

@ingvagabund
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aveshagarwal, ingvagabund
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2018
@openshift-bot
Copy link
Contributor

@aveshagarwal: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member

Closing in favor of #20615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@sttts sttts Awaiting requested review from sttts

Assignees

@ingvagabund ingvagabund

Labels
lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aveshagarwal @ingvagabund @openshift-ci-robot @openshift-bot